Oliver M. Crook

Scifer review This looks pretty high standard for an initial submission and most things look good. If there are any notes you can clear up then that would be great....

Exactly, I think this would be much better and easier for development in the future.

This looks good to me @rodrigarc, I dont think you need to make anymore changes. I'm going to double check the code and check the build on a windows laptop.

Sorry, I already did this and forgot to update to accept.

Hi @jeffreypullin, Thanks for submitting `cardelino`, it'll take me roughly 10 days to look through the package or so. It may be worth looking at the build report to see...

# Cardelino This looks really good, thank you for the contribution. I found it well documented and easy to follow. The R code has a consistent style and is easy...

Hi @jeffreypullin, just got back from annual leave, I'm going to start going through my reviews today

Thanks @jeffreypullin for the revisions and looks like the package is almost there. There are a couple of points I'm still unsure about -[ ] Checking function inputs more carefully....

Hi @jeffreypullin Just discussing with the core team on this point and I'll get back to you soon hopefully!

Sorry to get back to you slowly, coul you have a look at the: https://bioconductor.org/packages/release/bioc/html/VariantExperiment.html object to see if that would work? If not we can avoid using a dedicated...