Olivier Chafik

Results 120 comments of Olivier Chafik

Quick note that this can be now tested on the main Web Playground which also just got a long list of other upgrades (customizer, exports to multiple formats, modelviewer, tweaks...

@kintel Thanks for reviewing! I'd say let's indeed cover updates in follow up PRs, if you're happy to merge this for now

> If I understood this correctly this are great news! Thank you very very much. @Rami5743 My pleasure! > I did not understand the phrase (includes OFF color import /...

> @ochafik I tested this before, my finding is that hull is not taking that much time, and I feel that it is not that important comparing with changing the...

> @ochafik Is this ready to go? A bit swamped atm., but I can put it on my review list. @kintel Yes it is, hopefully :-)

@kimkulling Thanks! FYI I've now hacked a workaround into the [OpenSCAD Web Playground](https://ochafik.com/openscad2/) where I post-process in JavaScript the 3MF generated by Assimp (compiled to WASM w/ OpenSCAD by Emscripten)...

> [@ochafik](https://github.com/ochafik) WDYT, is this something that can/will be supported? @CISC Ah, absolutely, I'll look into it. I want the time to be overridable by flag (for tests) & synced...

> > This variable in particular though should be replaced with the [strftime_now](https://huggingface.co/docs/transformers/v4.50.0/en/chat_templating_writing#callable-functions) function in the template. > > But [minja](https://github.com/google/minja) `strftime_now` only work with `%Y-%m-%d` not work other format-codes...

Hey @MoonRide303 , @henryclw , thanks for reporting this! Are you both experiencing this on Windows? Could you try fetching the template with `./scripts/get_chat_template.py google/gemma-2-2b-it > gemma2.jinja` ? (or probably...

@henryclw Thanks for the extra repro details! I was able to reproduce this ~~when building with `-DLLAMA_LLGUIDANCE=1`~~. Looks like I left a typo in chat.cpp / common_chat_params_init_without_tools, will send a...