obligaron

Results 22 comments of obligaron

I think this is a good change. 👍 Especially when you look at the multiplayer workaround. 🥴 Some questions related to the pr: 1. Should we have different kill-counter per...

4, We could use `int32_t` when we write the old format for compatibility and only use `int64_t` for the new file. We have done something similar in other cases. 5,...

> Do you mean to read int32_t when reading from an old savefile, but to write/read int64_t in the new section? This could be possible. I could also use this...

side-note: #4536 also tries to use slot back colors to differ between own player and inspected player. So we should think about for what we want to use the colors?...

I checked all arches I could find (perhaps missed one) and set for all of them block missile and block lightning constantly. They are often not set consistent. Examples from...

Sorry if I was unclear. I have no problem with recording a new timedemo (for this pr and future pr's). But if we don't want to take this changes (cause...

I think it would be a good idea to look over all cathedral tiles. The other tile sets are not tested with the shareware, so they don't affect the demo...

I checked all cathedral tiles again with the [new tooling](https://github.com/diasurgical/devilutionX/pull/5264#issuecomment-1234976881). The changes helped a lot. 🙂 👍 Note: I didn't test all cases.

Note: I also found a seed that generates different levels between master and the previous release (hellfire, dungeon level 2, seed 2380102989 with butcher and poisoned water quest). With this...

@AJenbo could you take a look? If this is merged, I could use the new missile helpers introduced in #4632 (separate pr, cause i also want to change `scrollrt.cpp`). 🙂...