Predrag Gruevski
Predrag Gruevski
No worries at all! All this is super tricky, especially given the breadth of users' workflows we have to support. I appreciate the care and attention you're putting into it....
Four lints to go here, and we can close this issue! 🚀
cc @estebank in case any SemVer edge cases I didn't notice jump out at you. No worries if you're too swamped with other work, just wanted to make you aware...
Changing only how the value is produced doesn't seem breaking to me. I can't think of a "witness" program that demonstrates the breakage by working fine on one version and...
Thank you! We do use `#[automatically_derived]` in a couple of lints already, so it's a good idea to use it here as well. I guess the advice is "please don't...
The invocation of `cargo-semver-checks` that triggers the false-positives is this: ``` $ cargo semver-checks --manifest-path ../tokio/tokio-stream/Cargo.toml --release-type minor --exclude benches --exclude examples --exclude stress-test --exclude tests-build --exclude tests-integration Finished `release`...
cc @Darksonn on the off chance you notice this while working on `tokio`. Scanning on new `tokio` versions should be fine, since the path dependency on `tokio` will point past...
I agree, I don't think you'll hit it either. Just wanted to preemptively warn you just in case, so you don't end up debugging a phantom breaking change. Yes, we'll...
It seems that `cargo package` would produce a `.crate` file. Could you elaborate on how we might use that file to generate rustdoc JSON, and whether we'd want to do...
I'm still having a bit of trouble fully wrapping my head around this (perhaps because it's late over here and I should go get some sleep...) Is the idea that...