Predrag Gruevski

Great questions! > I'm assuming it's a major-level change based on other violations like changing an established `repr`, although I couldn't find anything on [the cargo semver page](https://doc.rust-lang.org/cargo/reference/semver.html). for no_mangle/export_name...

Hi @briansmith, thanks for your suggestions. To help me understand the context of your suggestions better, have you had a chance to review the lints `cargo-semver-checks` already offers for `pub`...

That's an excellent idea, assuming we can find a way to implement it. Have you had a chance to review the technical details of the project, so as to suggest...

I'd give them ~24h to reply, but they recently posted elsewhere they are taking a break from maintaining their projects so if we don't hear back then I'd assume that...

No worries, thank you for following up! It's worth making sure we dot our "i"s and cross our "t"s.

The third checkbox was handled in #650.

Thanks for looking into this. Have you had a chance to check out [the schema](https://github.com/obi1kenobi/trustfall-rustdoc-adapter/blob/8244b6a76f985769b222f8c62783bf3cea87dc6b/src/rustdoc_schema.graphql) these queries are written against, or tried out some queries in [the rustdoc query playground](https://play.predr.ag/rustdoc)?...

That error message means there was another, earlier error that caused the `Once` data structure to not be set up correctly. Scroll up in the log and you should see...

Yeah! So I guess this issue seems done -- nice!

Agreed, not done yet. Reopening. We probably want to do a review of the lints and test cases here, to ensure they are consistent and have minimal overlap. It looks...