Predrag Gruevski

Add "unit struct to normal struct" case to semver.md

8

### What does this PR try to resolve? Changing a public unit struct to a normal struct appears to be a breaking change that should require a major version bump:...

Document that adding `#[non_exhaustive]` on existing items is breaking.

1

### What does this PR try to resolve? Adding `#[non_exhaustive]` to an existing struct, enum, or variant is almost always a breaking change and requires a major version bump for...

Tracking issue: Additional checks, both semver and non-semver

30

This is a list of all not-yet-implemented checks that would be useful to have. Some of these require new schema and adapter implementations as well, tracked in #241. In addition...

It would be useful to export the discovered semver issues and/or warnings in a machine-readable format (e.g. JSON). For example, this would allow the automatic inclusion of changes that may...

Re-exports of items cannot be semver-checked

1

Unfortunately, `rustdoc` JSON output does not seem to output re-export information in `paths`, so we don't seem to be able to get information on re-exports which we can query for...

Round-trip failure: untagged enum containing Vec variant is improperly deserialized

11

Consider the following types: ```rust #[derive(Debug, PartialEq, Eq, Serialize, Deserialize)] #[serde(untagged)] enum MyValue { Int(i64), String(String), Enum(Enum), List(Vec), } #[derive(Debug, PartialEq, Eq, Serialize, Deserialize)] enum Enum { First(String), Second(i64), }...

Improve type checking in query pagination and AST manipulation code.

2

Includes type-level fixes for handling `InlineFragmentNode` AST values in query pagination code, a couple of new helper functions, and type hints for the AST manipulation module. Based on the tests...

Per https://github.com/kensho-technologies/graphql-compiler/pull/710#discussion_r362062727 the `Expression.to_sql()` function contract isn't precisely defined, making it somewhat difficult to implement.

Improve test coverage of query pagination code for queries with type coercions

2

While adding types to the query pagination code, I realized that a good chunk of the code appears to implicitly assume that queries do not contain type coercions: for example,...

Improve Codecov settings to take advantage of "after_n_builds" and (if possible) flags

2

Courtesy of @jerrode: 1 thing I'd definitely recommend to deal with your notifications issue: `after_n_builds` in the .yml so Codecov knows to wait to notify until everything is uploaded https://docs.codecov.io/docs/codecovyml-reference#codecovnotifyafter_n_builds...