Kris Nuttycombe

Ensure symmetry of transparent output handling between `put_blocks`, `store_decrypted_tx` and `store_sent_tx`

1

> AFAICT (at least as of the first commit in the PR), this `NULL AS from_account_id` is preserved, because there is still an asymmetry between transparent and shielded (we are...

zcash_client_backend: Expose the set of unexpired transactions having zero confirmations.

2

This is needed for the client to be able to determine whether to rebroadcast a transaction.

zcash_client_backend: Report confirmations of pending balance in wallet summary.

1

Return the minimum over the number of confirmations for the set of notes that are included in the pending balance. This can be used to make rebroadcast determinations, and can...

It turns out that the `GetTransaction` method added to `lightwalletd` is horribly broken, because it does not correctly propagate the output of the `getrawtransaction` JSON-RPC method. It says here "optionally...

…commitment tree corruption. This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of...

Zcash rpc error codes are not being correctly mapped to GRPC responses.

1

**What is the bug?** `lightwalletd` appears to be directly propagating RPC errors from `zcashd` and `zebra`, instead of reinterpreting them as the correct GRPC error types. Here is an example...

Add the ability to query for the transaction that spends a specified transparent outpoint.

8

**What is your feature request?** Add a GRPC method: ``` message OutPoint { bytes txid = 1; // transaction identifier uint32 output_index = 2; // index of the output in...

Support empty block range end in `getaddresstxids` calls.

6

Please ensure this checklist is followed for any pull requests for this repo. This checklist must be checked by both the PR creator and by anyone who reviews the PR....

clippy::let_and_return incorrectly applies when a temporary is needed to resolve borrows

4

I tried this code: ```rust let result = stmt_select_note .query_and_then( named_params![ ":txid": txid.as_ref(), ":output_index": index, ], to_spendable_note, )? .next() .transpose(); result ``` And ran: ``` cargo clippy --all-features --tests --fix...

Standardize a protocol for creating shielded transactions offline

16

@str4d commented on [Mon Jul 17 2017](https://github.com/zcash/zcash/issues/2542) With t-addrs, it is possible to run a "split-node" configuration, where the user runs two nodes: - a watching node, which downloads the...