Nathaniel Starkman

Results 683 comments of Nathaniel Starkman

> pytest-github-actions-annotate-failures That's a useful tool! Didn't know about it, thanks!

@wesselb @PhilipVinc what do you think of this simple solution? There's definitely room for improvement, as indicated in the comment, but I think since this is private API it's good...

@PhilipVinc some really good points! Just for completeness, this also helps address the case ```python @jit @dispatch def myfun(a: jax.Array, b:int): return a * b @jit @dispatch def myfun(a: jax.Array,...

@wesselb, maybe is this related to your suggestion of a `cache` ? Or is this a separate complication?

See the opening comment of https://github.com/beartype/plum/issues/154#issue-2329848202. `jit` compiles away the `plum` dispatching, which is great for speeding up the code. Prior to this PR, when a new dispatch was added...

Ah. Good catch. I didn't write tests yet for this, which would have caught this mistake. This is the difference between the example I gave in #154 and here. Yes,...

It's definitely not ideal, but so long as a user imports in all modules (as in registers everything) then it's not so bad. It's only when new dispatches are registered...

Maybe @patrick-kidger can advise on how to best make `plum` and `jax` play well together?

@patrick-kidger. Thanks for the info! Are you suggesting that instead we just add something to the docs showing how `jit` + `dispatch` can work together, but also showing how this...