Nathaniel Starkman

Stellarium has different constellation modules. Any chance we can hook into that? If we have no plans to actually support other constellations, I'm in favor of pruning dead code. I'm...

> If we have no plans to actually support other constellations, I'm in favor of pruning dead code.

Are we good to merge this so #16630 can go in as well?

> We could have an "Internal API" label and a corresponding "internal" piece for the changelog snippets. 👍 And maybe use a ``` For Developers - entry 1 - entry...

> If you think the change log should be expanded to include everything then we should stop writing separate change log entries and instead the change log should be compiled...

Cool! I think these modest speed improvements are from reductions in function call overhead. As @eerovaher says, further speedups may be possible by refactoring with performance in mind. We should...

> In CPython, `a.__class__ is A` is about 10% faster than `type(a) is A` @mhvk users can override `.__class__` — e.g. so that `a.__class__ == B` — but `type(a)` bypasses...

> a quick note is that this may clash with https://github.com/neutrinoceros/astropy-APEs/pull/1 I think one of the lovely things about mypyc is that it shouldn't! astropy would remain pure python, we'd...

> replacing `try/except` with `isinstance` checks I largely agree, but I just want to highlight the difference in performance: `try/except` is faster than `isinstance` if there's no error since the...

> I think people using astropy are doing a lot of unit conversions implicitly. E.g., any time you use coordinates in degrees, there will be lots of conversions to radians....