Nathaniel Starkman
Nathaniel Starkman
The very good reason is "Positional-only parameters give more control to library authors to better express the intended usage of an API and allows the API to evolve in a...
Looking at this more, I'd like to test this with a type checker. I'm confident in `__all__`, but IDK how importing to public API from a private `__init__.py` works. If...
No api changes.
Stuff that needs to be fixed: - https://github.com/astropy/astropy/blob/main/astropy/cosmology/_src/funcs/comparison.py doesn't list `cosmology_equal`, but it's in https://github.com/astropy/astropy/blob/main/astropy/cosmology/_src/funcs/__init__.py.
See main.py in https://play.ty.dev/313a15da-739e-4797-a10b-ae4cace54395 for how imports with a hierarchical structure might be complicated. Needs investigation! Edit: https://play.ty.dev/313a15da-739e-4797-a10b-ae4cace54395 shows this may work well, with `ty` at least.
@pllim. I know it's not elegant, but the following monkey-patch works and is safe on all matplotlib versions. It needs to be applied before subclassing Polygon. ``` Polygon.__init__.__doc__ = Polygon.__init__.__doc__.replace(...
@pllim hmm. that's odd. When I ran into this problem in #11118, I solved it with https://github.com/astropy/astropy/blob/54e25d3fea11d33bb9bb53e265174949d16da898/astropy/visualization/wcsaxes/patches.py I see in 11464 that the monkey-patch is only applied within an if-statement....
@pllim. I removed that part of the patch because I found it didn't have an effect. The matplotlib docs use `` `.CapStyle` ``, which as a relative path can't be...
We could try removing https://github.com/nstarman/astropy/blob/1a40abccc9ac6f4e24ffca87f4249cc72b83a591/astropy/visualization/wcsaxes/patches.py#L14-L23 That was the monkey-patch
I should have time next week to look at this in more detail. Making a reminder...