Nick Ripley

Results 24 issues of Nick Ripley

This test does not verify anything useful. It modifies several private variables/fields to change the behavior of the profiler, and makes assertions about the modified behavior. If we change the...

no-changelog

`internal/telemetry.TestProductChange/profiler_start,_tracer_start` is flaky. [Example flake](https://github.com/DataDog/dd-trace-go/actions/runs/9010314160/job/24756159866#step:6:433): ``` === FAIL: internal/telemetry TestProductChange/profiler_start,_tracer_start (1.00s) telemetry_test.go:74: too many telemetry messages (expected 3) --- FAIL: TestProductChange/profiler_start,_tracer_start (1.00s) ```

flaky-test

### What does this PR do? Move the agent default URL resolution logic to `internal` so it can be shared by the tracer and profiler. This is motivated by the...

### What does this PR do? Add hidden flags to enable profiling Orchestrion. Options for writing CPU and heap profiler, as well as execution traces, with a configurable path prefix....

### What does this PR do? TODO - description TODO - this is broken right now, see #174 TODO - tests Here’s what I think we want to instrument: *...

### What does this PR do? For tracking adoption of SSI for profiling, record whether the profiler was added using Orchestrion and how the profiler was activated, following the internal...

### What does this PR do? Set `GOTOOLCHAIN=local` for our unit tests. I didn't change the `go get -u` smoke tests. Those tests are inherently incompatible with `GOTOOLCHAIN=local`. We could...

TODO - description ## Motivation ## Changes ## Workflow 1. ⚠️ Create your PR as draft ⚠️ 2. Work on you PR until the CI passes (if something not related...

### What does this PR do? **WIP:** my first approach (add a "limited" field to the operation) was wrong since the rate limiter is a global thing and each benchmark...

### Tracer Version(s) n/a ### Go Version(s) n/a ### Bug Report Sometimes profiler tests fail with the error `bad multipart form: unexpected EOF`. For example: https://github.com/DataDog/dd-trace-go/actions/runs/15781660177/job/44488540113#step:3:160 ``` --- FAIL: TestDebugCompressionEnv...

bug