orchestrion
orchestrion copied to clipboard
WIP: instrument net/http.ServeHTTP implementations
What does this PR do?
TODO - description TODO - this is broken right now, see #174 TODO - tests
Here’s what I think we want to instrument:
http.Handlerinterface implementations that will be used by anhttp.Serverhttp.HandleFunc(“...”, foo)andhttp.(*ServeMux).HandleFunc(“...”, foo)should have foo instrumented- An
http.HandlerFunc(explicitly created) should get instrumented
Motivation
Fixes #173
Reviewer's Checklist
- [ ] Changed code has unit tests for its functionality.
Closing in favor of #403
Codecov Report
Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
Project coverage is 56.48%. Comparing base (
0acfd19) to head (71230cd). Report is 51 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| instrument/http.go | 0.00% | 8 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 58.16% 56.48% -1.68%
==========================================
Files 151 105 -46
Lines 10976 5051 -5925
==========================================
- Hits 6384 2853 -3531
+ Misses 4124 1873 -2251
+ Partials 468 325 -143
| Components | Coverage Δ | |
|---|---|---|
| Generators | 78.38% <ø> (+1.40%) |
:arrow_up: |
| Instruments | 61.33% <0.00%> (-26.73%) |
:arrow_down: |
| Go Driver | 48.55% <ø> (-24.26%) |
:arrow_down: |
| Toolexec Driver | 42.84% <ø> (-28.05%) |
:arrow_down: |
| Aspects | 71.34% <ø> (+0.49%) |
:arrow_up: |
| Injector | 72.71% <ø> (-0.44%) |
:arrow_down: |
| Job Server | 54.18% <ø> (-9.85%) |
:arrow_down: |
| Integration Test Suite | 38.68% <ø> (-9.81%) |
:arrow_down: |
| Other | 56.48% <0.00%> (-1.68%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| instrument/http.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
- Flaky Tests Detection - Detect and resolve failed and flaky tests