Nick Ripley

all: use depaware to track core package dependencies

1

The `github.com/tailscale/depaware` tool lists the dependencies for an individual package. `depaware` also identifies OS-specific dependencies and dependencies which use unsafe or `cgo` code. `depaware` produces a file which is checked...

profiler/internal/cmemprof: make C.malloc safe to profile

3

This commit adds workarounds to make `C.malloc` safe to profile. Essentially, we replace `C.malloc` calls with our own idential version which includes safety checks that `C.malloc` lacked. Previously, this function...

ddtrace/tracer: TestAutoDetectStatsd fails, receives traceproftest metric

2

See: https://app.circleci.com/pipelines/github/DataDog/dd-trace-go/3620/workflows/aa0499a0-d8ab-4454-8027-d849db97a89f/jobs/26473 The failure looks like this: ``` Failed === RUN TestAutoDetectStatsd/agent/default option_test.go:69: Error Trace: option_test.go:69 option_test.go:129 Error: "datadog.tracer.traces_dropped:2|c|#lang:go,version:v1.39.0,lang_version:go1.16.12,service:traceproftest.test,runtime-id:55f8f976-2765-4a7c-a2a9-4bf3ffc108ee,reason:send_failed\n" does not contain "name:1|c|#lang:go" Test: TestAutoDetectStatsd/agent/default --- FAIL: TestAutoDetectStatsd/agent/default (0.00s) ```...

All tag values are treated as strings in the Datadog UI. In particular, `proflie_seq` is treated as text when submitted as a tag, which breaks sorting. Instead, we can add...

`dd-trace-go` has lots of duplicated logic around agent discovery, including finding the agent URL, handling UDS, and detecting agent features. Move this logic into a shared package. The shared discovery...

go: document adding C function calls to CPU profiles

1

### What does this PR do? Documents how to add C function call information to Go's CPU profiles. ### Motivation Go's CPU profiles lack detailed information on time spent running...

proposal: runtime/pprof: make the CPU profile maximum stack size configurable

10

CPU profiles currently have a [hard-coded](https://cs.opensource.google/go/go/+/refs/tags/go1.19.1:src/runtime/cpuprof.go;l=23) maximum of 64 frames per call stack. However, this limit can be too low, especially when programs use middleware libraries or deep recursion. Call...

As of `main` at commit f986cc53879c8466c152e607c4f0e18a0b47ff2d, the gRPC contrib tests fail with shuffling enabled (see #2265). There appears to be interference between the `TestClientNamingSchema` and `TestIssue2050` test cases. Example: ```...

Example failure (which passed after re-running on the same commit): https://github.com/DataDog/dd-trace-go/actions/runs/4008861739/jobs/6883545759#step:6:157 ``` === Failed === FAIL: profiler TestStopLatency (3.27s) profiler_test.go:227: profiler took 862.397191ms to stop ``` The test attempts to...

### What does this PR do? What is the motivation? We have an Agent integration for collecting profiles from Go services through a Go standard library debug HTTP endpoint. Document...