Nicola Soranzo

Results 101 comments of Nicola Soranzo

> https://github.com/galaxyproject/galaxy/actions/runs/3089464955/jobs/4997115418#step:7:1442 should be unrelated, we might have to pin numpy to a version that works on python 3.7 No, it's actually a [mypy bug](https://github.com/python/mypy/issues/13627), whose fix will be included...

@FredericBGA Is this ready from your side? It was marked WIP at a certain point (by @martenson).

It looks like that rebasing on top of https://github.com/galaxyproject/galaxy/pull/13977 broke the Toolshed tests added to `lib/tool_shed/test/functional/` in that PR. Also converter tests broke after the rebase (framework tests failure seems...

> I want to steal the code in here for running the tool shed via pytest... should I be patient and let this work out though? Is there something I...

After rebase, the converters tests pass (Selenium failure unrelated), so ready to merge!

If we don't remove it, maybe at least move it to a `deprecated/` subdirectory of tools, and remove it from the `lib/galaxy/config/sample/tool_conf.xml.sample` ? So people won't try to update it...

> > Can you go with [b7ad595](https://github.com/galaxyproject/galaxy/commit/b7ad595b7298729924a0744fba62ba7a6198410a) ? I'm not sure it's wise to remove tools, just for the potential loss of tool state. > > Will do. How about...

> I think that if you've had the tool installed (and you've run it at least once) you should keep it installed, so moving the location is also going to...

> Lock icon for unhiding not great. I think it's currently [eye-slash](https://fontawesome.com/icons/eye-slash?s=solid), which is also not great given that we use the "eye" icon to view the data.