galaxy icon indicating copy to clipboard operation
galaxy copied to clipboard

Drop nose

Open nsoranzo opened this issue 2 years ago • 4 comments

It's deprecated and unmaintained, and breaks under Python 3.10 (xref. https://github.com/galaxyproject/planemo/pull/1234 ).

TODO:

  • [x] lib/galaxy_test/base/instrument.py
  • [x] lib/galaxy_test/driver/driver_util.py
  • [ ] Fix converter tests

How to test the changes?

(Select all options that apply)

  • [ ] I've included appropriate automated tests.
  • [x] This is a refactoring of components with existing test coverage.
  • [ ] Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • [x] I agree to license these contributions under Galaxy's current license.
  • [x] I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

nsoranzo avatar May 11 '22 17:05 nsoranzo

It looks like that rebasing on top of https://github.com/galaxyproject/galaxy/pull/13977 broke the Toolshed tests added to lib/tool_shed/test/functional/ in that PR. Also converter tests broke after the rebase (framework tests failure seems unrelated). Help welcome!

nsoranzo avatar Aug 30 '22 23:08 nsoranzo

Taking a quick look at that.

jmchilton avatar Aug 31 '22 14:08 jmchilton

I want to steal the code in here for running the tool shed via pytest... should I be patient and let this work out though? Is there something I can do to push this forward?

jmchilton avatar Sep 15 '22 23:09 jmchilton

I want to steal the code in here for running the tool shed via pytest... should I be patient and let this work out though? Is there something I can do to push this forward?

I think if you could help getting https://github.com/galaxyproject/planemo/pull/1232 merged, then this one should quickly become ready as well.

nsoranzo avatar Sep 15 '22 23:09 nsoranzo

After rebase, the converters tests pass (Selenium failure unrelated), so ready to merge!

nsoranzo avatar Nov 02 '22 11:11 nsoranzo