nodejs.dev icon indicating copy to clipboard operation
nodejs.dev copied to clipboard

warning error: cleanup staging deploy CI/CD

Open tahseenio opened this issue 3 years ago • 4 comments

Description

Everytime a PR is created the cleanup staging deploy yml file produces a warning "service_account_key" has been deprecated. Please switch to using google-github-actions/auth which supports both Workload Identity Federation and Service Account Key JSON authentication. For more details, see https://github.com/google-github-actions/setup-gcloud#authorization

Steps to reproduce

Create any PR and the warning will show.

Expected result

There should be no warning messages during CI/CD.

Actual result

image

The "service_account_key" has been deprecated so this will need to be updated following https://github.com/google-github-actions/setup-gcloud#authorization

Environment

  • OS Version: Win11
  • Browser Version: Chrome Latest

tahseenio avatar Jul 04 '22 03:07 tahseenio

I am unsure how to go about this so others are welcome to fix this

tahseenio avatar Jul 04 '22 03:07 tahseenio

File that needs to be changed is here:

https://github.com/nodejs/nodejs.dev/blob/0b3901550fdece75d7d573f6776b66788d0261de/.github/workflows/cleanup-staging.yml

tahseenio avatar Jul 04 '22 04:07 tahseenio

@MylesBorins looks like this might be the one that would be supported for the current setup https://github.com/google-github-actions/setup-gcloud#service-account-key-json. I guess it would be combining the two existing keys into a JSON file, but it's pretty light on details

nschonni avatar Jul 04 '22 05:07 nschonni

I guess you'd have to first use the auth action, then the setup-gcloud after that

Sheharyar566 avatar Jul 28 '22 12:07 Sheharyar566