Nick Fox
Nick Fox
> As it's not in the scope to have a yaml editor for the deployment, perhaps a modal with a table where user can add/edit/delete annotations could work. > >...
> I wonder if the user will have the permissions to do that? I can't think off the top of my head about a specific case, but I have to...
Agreed that better docs are needed and are a higher priority. I don't believe it replaces this issue though as knowing what to configure and making it easier to configure...
> Perhaps, we should first deprecate it with a warning in the login form. And some time later, remove it. > Just to give people a chance to do proper...
From what testing I did it results in about a 35% speed up of overall graph generation with 100-150 workloads across 5-10 namespaces.
Some representative tracing samples. Before:  After:  You can see much less time is spent in the `GetNamespaceXHealth` calls since we're no longer...
> I'm not seeing where we actually use the graph rates to calculate the health server-side. Moving the health calculations server side isn't a part of this PR but it...
CI is failing because there's a problem with the idle nodes option. It's causing graph generation to get stuck even though the backend response returns successfully.
> So, we should create another ticket for the flash login screen? Yes I'd say they're separate issues. This issue is just about skipping the login page to select a...
@matejnesuta there's a CI failure for the newly added test if you wouldn't mind looking into it: https://github.com/kiali/kiali/runs/8243955353?check_suite_focus=true