Nick Fox

Results 123 comments of Nick Fox

Just to clarify, `accessible_namespaces` limits where **Kiali** will look for resources in the cluster and the goal here is to check the user's permissions to scope where Kiali looks for...

> I think my response was also including the use of informers to access the Kubernetes API, I'm also including that in my thoughts about this, and for that list...

This continues to plague CI and should be added to the backlog.

You'll hit this much more often locally when running the tests with the `-race` flag: `make test-race`.

> The external URL of Grafana is not enabled by default. The `url` field is empty but the service is enabled by default in both the server: https://github.com/kiali/kiali/blob/master/config/config.go#L555 and the...

> I don't know how much more obvious Kiali can make it ? :) It says right in the UI message, "grafana URL is not set in configuration": The non-obvious...

This issue is for enabling auth in the e2e CI environment which currently runs in anonymous mode: https://github.com/kiali/kiali/blob/master/hack/setup-kind-in-ci.sh#L153 for both the frontend and the backend tests. I think the "login"...

It'd be good to do this still to make the cypress tests more similar to a production environment. There are sometimes subtle ways the tests can fail when auth is...

> What do you mean by that environment? In the Github actions CI pipeline, Kiali runs in anonymous auth mode. This issue is about enabling auth for the Github actions...

Sorry I missed this one. I'd agree with @israel-hdez that this one is important but not urgent since, from what I understand, the implicit flow just makes it easier for...