Nick Fox

Results 123 comments of Nick Fox

I think we should instead do #7188 in lieu of this issue. Closing...

This might actually be a duplicate of: https://github.com/kiali/kiali/issues/7305

I can't say for sure but I think this is the line that is failing: https://github.com/kiali/kiali/blob/5f59bc2c2f56dc70065b948657892b9cf925154e/frontend/cypress/integration/common/graph_context_menu.ts#L35-L37

> I'm testing this now. I'm curious why these are removed... there must have been a reason I think if you add back the `deploy-kiali.sh` call then you will end...

@jmazzitelli I think if you run these separately it might still work on minikube: ``` hack/istio/multicluster/install-multi-primary.sh -mm true -kudi true hack/istio/multicluster/deploy-kiali.sh --single-kiali true --cluster1-context east --cluster2-context west --kiali-auth-strategy openid --keycloak-address...

~I'd say it's bigger than that. It's many of the settings under [external_services.istio](https://kiali.io/docs/configuration/kialis.kiali.io/#.spec.external_services.istio) like `config_map_name`. Some of these settings are used in various places like validations:~ https://github.com/kiali/kiali/blob/976461bbf9099f4f6228442f918c106ae8d0a9dc/business/istio_validations.go#L407 ~and probably would...

There's a lot of `TODO: multi-primary support` littered around the backend right now. These are not specific to the mesh page and cover a few different features, especially validations. I'm...

> There's a lot of TODO: multi-primary support littered around the backend right now. Actually it'd probably be better to create a new issue for this. This issue is about...

Yes it can be part of or a followup to that work.

> Can you provide more contexts on it? @nrfox Sure I'll update the description.