Nick Cameron
Nick Cameron
I think maybe the anti-pattern is something more specific about `PhatomData` and ZSTs, rather than any use of `PhantomData`. In particular, using PhantomData to support phantom types is exactly what...
> Making macro take arguments from the context would make them non-hygienic. There are ways to safely allow this kind of hygiene-bending, if we wanted to
> I don't necessarily agree with this statement. Code coverage is an essential part of the development lifecycle. So, personally, I strongly disagree with this. I think code coverage is...
> Would require getting IRC nicks for team members who use different IRC and GH nicks. Highfive does this by using the Rustaceans API - https://github.com/nrc/highfive/blob/master/highfive/newpr.py#L316
for fmt-rfcs, there are no other teams involved, so it will always be the style team. Adding `style` to the rfcbot command feels worse than having a t-style label on...
I think you need to add `default-features = false` to your raft dep. Was there any more to the error message? That is just showing how you ran the RLS....
These might be good things to try, for sure. I would also like to try just using some explicit lifetimes. Usually (not always of course) refactoring code to fit with...
This is RFC 21: https://github.com/tikv/rfcs/pull/21
There's still a lot of work to do here, but I believe that #269 gets us to a state where we can make a 0.1 release.
I noticed that the gc function does not use the gc request, which is a bit confusing. AIUI, we currently gc locks but not deleted data (the delete ranges step)...