Nick Cameron
Nick Cameron
And @rust-lang/libs-api I'd love some feedback for the naming of `clone` (possibly, `reborrow`, see @danielhenrymantilla's comments). Data-wise (i.e., what happens at runtime), it is doing a clone, thus the name,...
I think with this API it is fine just to use the original reference because that buffer in the BorrowBuf cannot be swapped out
> yes, but what if you don't have the original reference for some reason? Do you have a use case in mind? In general, the creator of the buffer should...
> it may be easier to use only one variable like so I don't think this works because of the borrowing rules around temporaries > passing a BorrowBuf or BorrowCursor...
@rustbot label +T-libs-api -T-libs
@rustbot label +S-waiting-on-review -S-waiting-on-author
r? @Mark-Simulacrum or @joshtriplett or @sfackler or @BurntSushi (pinging some folk who I know have reviewed this area somewhat recently)
> I believe this would need an ACP (per https://github.com/rust-lang/rust/pull/97015#issuecomment-1206628480, "Introducing new or changing existing unstable library APIs"), but otherwise happy to review the actual implementation. I'll mark as waiting-on-author...
I've addressed the reviewer comments (except for the naming of `clone` where I'm waiting for more feedback). `BorrowedCursor` now only has a single lifetime, which is obviously nicer and I...
Renamed clone -> reborrow. All comments are addressed. Could I get a re-review please?