Nick Cameron
Nick Cameron
The link is broken for me. Does that mean we don't need to support the gc message at all?
@ekexium is it ok to close this issue now? We have a `gc` function, which I think does what it should.
E.g.: ``` thread 'cases::cancel::test_client_cancel_on_dropping' panicked at 'expected cancel, but got: RemoteStopped', tests/cases/cancel.rs:127:24 stack backtrace: 0: backtrace::backtrace::libunwind::trace at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.29/src/backtrace/libunwind.rs:88 1: backtrace::backtrace::trace_unsynchronized at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.29/src/backtrace/mod.rs:66 2: std::sys_common::backtrace::_print at src/libstd/sys_common/backtrace.rs:47 3: std::sys_common::backtrace::print at src/libstd/sys_common/backtrace.rs:36...
Haven't seen this for a while
I think we shouldn't use `Any`, but we should allow to implement an `Error` trait and then take trait objects of that `Error` type. Ideally we would use the trait...
Hitting this one a lot recently.
I'm seeing this again in https://travis-ci.org/pingcap/grpc-rs/jobs/559681593 with `cargo test --features "openssl" --all`, which doesn't make sense, since it should be ignored after #310. I still can't reproduce locally (Mac OS)...
It does use a fair bit of the Cargo edit code, mostly toml-edit, to be fair, but also the test infra. I don't think the styling has to be specific...
I'm not sure if this is an RLS issue or a Racer one (or maybe even an issue for the VSCode extensions). Given that it is fairly easy to know...
Looks like we need to set the `containerName` field of the `SymbolInformation` we return for symbols. We have this info from the compiler, but we need to feed it through...