Nikola Prokopić

Results 20 comments of Nikola Prokopić

We can keep `AzureManagedControlPlaneSpec.VirtualNetwork` and its current behavior, with improvements from https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/1590 (fixing the deletion problem for BYO VNets), and keep that part of the `AzureManagedControlPlaneSpec`, have it applied to...

> It's been a while since we've engaged this issue. Are we able to concretely define what work needs to be done here @LochanRn @nprokopic? Currently VNet where the managed...

Current blockers for this: 1. OS type not explicitly specified for the managed node pool, described here https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/1174 2. SSH key update error ``` "error creating AzureManagedControlPlane default/aks6adopt: failed to...

About SSH keys, in theory it might work if the AKS cluster was created with a single SSH key, and that same key is set in the CR. I didn't...

Some concrete actions here would be to add an e2e test for adopting an existing AKS cluster with features that are currently supported in CAPZ. We can the iterate from...

> we've added e2e since I made the previous comment. If someone could manually test this (easy), that would be enough to close this out IMO. I have tested this...

I could tackle this list :) but maybe refactoring from https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/757 should be done first?

Slightly related, while working on https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/1634, I added a unit test for `AzureClusterIdentity` conversion, since it was missing, and it failed, so I will also include `AzureClusterIdentity` conversion fix in...

Hi @christophermclellan, is there any update about multi-node Kubernetes support in Docker Desktop?

> When I run the branch locally and render a cluster manifest for either a v0.75.0 or 0.76.0-alpha.1` cluster app version I see that default apps is included For `v0.75.0`...