Nikola Prokopić
Nikola Prokopić
Hi folks, here is a draft pull request that is adding Private Links support that is described in this issue https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/3400. The feature is intended for clusters with private networking,...
Thanks for the review here @Jont828! :) I got back from vacation last week, so I'm continuing with this this week, adding tests and addressing the review comments.
I'm adding missing tests first, addressed some of the comments along the way. Then after adding all (or most of) required tests I'll address other comments (for the sake of...
@Jont828 as most of the review comments has been addressed, large amount of tests has been added (alongside fixing few issues discovered along the way) and this has been successfully...
There is a broken links error: ``` ERROR: 1 dead links found! [✖] https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#capz-pr-e2e-main → Status: 0 ``` Not sure why, as I can successfully open that link.
> There is a broken links error: > > ``` > ERROR: 1 dead links found! > [✖] https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#capz-pr-e2e-main → Status: 0 > ``` > > Not sure why, as...
> @nprokopic Hey just to follow up, are you still working on this or do you need any help? Hey folks, sorry for the radio silence, other work priorities got...
/remove-lifecycle stale
> Will this (Azure Private Link) addition to CAPZ give users a better way to access Azure Services? This is about a better way to access [private workload cluster API...
Can we keep the file names sorted here? And ideally also grouped by top-level directory e.g.: ``` .github @person1 @person2 chart @person1 @person3 pkg/controllers @person3 @person4 pkg/controllers/ @person3 @person4 pkg/server...