Wolfgang
Wolfgang
What's purpose of introducing different exit codes?
I get that, but I don't see the point of introducing different exit codes for different errors. The script is so simple that it would have no benefits – we...
Thanks for the changes! I've noticed that ${SUDO} is wrapped in double quotes in your verison of the script. It results in 'command not found errors', I removed the double...
Just realized that it's probably because you didn't merge back my changes to the script
Apart from `${SUDO}` it seems to be fine – Having `${SUDO}` wrapped in double quotes results in an error every time `${SUDO}` is used. The errors are very easy to...
Rebase your branch against notthebee:testing please (only keep the authoritative nameservers function and the related stuff) Also, have you tested it as follows? 1. Purposefully setting the DNS record wrong,...
> What variants of the domain name in question are expected and/or required to match the same public IP address? Like I mentioned, domain.com, wg.domain.com and auth.domain.com > Perhaps a...
> > vars.yml, and > > Okay, by vars.yml --- you mean vars: section of inventory.yml ? Yes, sorry, that’s what I meant > The double read statements are awkward;...
> Aside from the unusual "${SUDO}" issue, which seems odd to me, the quoting of variables is recommended by shellcheck. That is pretty weird, I agree. But in my case,...
Thank you, I will test the changes and merge as soon as I can. One question – what is the purpose of the function `check_domain_dns_other_not_used`? P.S. For the future contributions,...