Steve Myers

> @notmandatory I got curious, what's the decision behind using `rusqlite` instead of something like `sqlx` ? > > _I'm not sure if this has been discussed before, please let...

I force pushed fixes mentioned above. I also updated the tests to persist multiple change sets with the scenarios: * add a tx with last_seen but no whole_tx * adding...

> ACK [acf3834](https://github.com/bitcoindevkit/bdk/commit/acf3834d0d0824c15a396940c3597c027180a0b7) > > I appreciate you taking the time to implement this and making it easy for reviewers. The approach to use private traits in store.rs looks like...

> Also, what do you think about naming the crate `bdk_sqlite`? The term `store` doesn't add any more meaning to the name. ~~On second thought can we leave the name...

I ran into a docs error that I fixed by removing the rust doc link in the README. Can add it back later after the crate is published but it's...

I renamed > Also, what do you think about naming the crate `bdk_sqlite`? The term `store` doesn't add any more meaning to the name. We discussed the naming at our...

@evanlinjin I merged your latest PR commits but removed `DbCommitment` and the `transform()` logic. `bdk_sqlite` already depends on `bdk_persist` so I don't see any reason why `Store` shouldn't use `persist::changesets::CombinedChangeSet`...

@evanlinjin great styling tip, I redid as you suggested and it look much better (I don't know what I was thinking with the traits 🙃 ) and removed the wallet...

I amended/force pushed another good suggestion from @evanlinjin to impl `PersistBackend` generic over types that can be converted `From` and `Into` `CombinedChageSet`: ```rust impl bdk_persist::PersistBackend for Store where K: Ord...

@nondiremanuel we didn't discussed this one yesterday but I think it belongs in alpha.3.