Steve Myers

Results 580 comments of Steve Myers

A small change but I think we should push to 2.0 milestone.

Concept ACK, this pattern should also be easier to extend to support future features like custom coin selection. But I'd like to push it to the alpha.4 release, alpha.3 is...

This one needs a rebase after alpha.5 release.

I screwed up while trying to push a CI fix to this PR. @willowenss please force push https://github.com/bitcoindevkit/bdk-cli/commit/5cc9dd44047570c8e148fc097d3c3ac812394879 from your local branch back to this PR branch. Then we can...

Looks like it's passing CI testing! Next steps are: 1. get commit signing working for your github account 2. then squash and/or reword your commits to be more descriptive 3....

Some new MSRV issues have cropped up, you'll need to amend your last commit to use these cargo update lines: ``` cargo update -p log --precise 0.4.18 cargo update -p...

I added this to alpha.4 since it should be a small fix.

@tnull this PR is still scheduled for the `bdk` `1.0-alpha.X` milestone release. But you are correct we also need to make sure the below PRs are released first: 1. bitcoindevkit/rust-electrum-client#121...

take a look at #1191 when this one is done.

This one needs a rebase after alpha.5 release.