bdk icon indicating copy to clipboard operation
bdk copied to clipboard

Upgrade to `rust-bitcoin` 0.31.0

Open tnull opened this issue 1 year ago • 4 comments

Describe the enhancement
rust-bitcoin 0.31.0 was recently released and includes changes that so far kept LDK from upgrading to 0.3X.Y (cf. https://github.com/lightningdevkit/rust-lightning/issues/2124#issuecomment-1791464639).

Additional context Probably currently blocked on https://github.com/rust-bitcoin/rust-miniscript/issues/622

tnull avatar Nov 07 '23 11:11 tnull

This now seems unblocked as rust-miniscript 11.0 was just released.

tnull avatar Nov 23 '23 08:11 tnull

@notmandatory Is the current plan to do this as part of 1.0-alpha.3 or 1.0-alpha.4? Trying to wrap my head around when I need for LDK to upgrade to be able to use the latest bdk/rust-esplora-client/rust-electrum-client in LDK Node.

tnull avatar Dec 12 '23 09:12 tnull

@tnull this PR is still scheduled for the bdk 1.0-alpha.X milestone release. But you are correct we also need to make sure the below PRs are released first:

  1. bitcoindevkit/rust-electrum-client#121 released in 0.19.0
  2. RCasatta/electrsd#74 released in 0.27.0
  3. bitcoindevkit/rust-esplora-client#79 released in 0.7.0
  4. bitcoindevkit/rust-hwi#91 released in 0.8.0

notmandatory avatar Dec 13 '23 16:12 notmandatory

Needs to stay in 1.0.0 milestone in order to not block LDK, but we need to check also other dependencies It makes sense to upgrade to rust 0.31.0 for beta (It doesn't seem 0.31 changes are too drastic)

nondiremanuel avatar Jan 25 '24 12:01 nondiremanuel

take a look at #1191 when this one is done.

notmandatory avatar Mar 18 '24 01:03 notmandatory