Orson Bradford
Orson Bradford
@Betree I'm going to tackle this as my first issue, since it appears to be an easy one.
I'm unclear if one or two templates are involved: `collective.comment.created.hbs` and/or `expense.comment.created.hbs`. I will look further to spot the contexts these are used. Maybe a different greeting name can be...
If this looks like the way to go, I can update all the email templates with a greeting as part of this PR, or a follow-up.
I can't decipher the automatic check GraphQL Inspector, "Error: Resource not accessible by integration". Perhaps that is due to a remote PR from the fork.
I think I've made an error in getting the user name. It looks like that might reside in the "userCollective". I'll make a change to get that.
If I comment out this line, the bug goes away in IE Edge: https://github.com/markmarkoh/datamaps/blob/master/src/js/datamaps.js#L264 So it looks like the browser detection needs to be extended to cover Edge - or...
Maybe use broader IE detection like http://stackoverflow.com/questions/33152523/how-do-i-detect-ie-and-edge-browser `if (document.documentMode || /Edge/.test(navigator.userAgent)) { ... }`