opencollective-api icon indicating copy to clipboard operation
opencollective-api copied to clipboard

feat: Create greeting partial.

Open nosro opened this issue 3 years ago • 3 comments

Addresses: https://github.com/opencollective/opencollective/issues/5872

This will allow more flexible greetings in email templates. A recipient name is used, if provided.

If a collective - wide notification is sent that collective name will be used rather than individual names.

Caveat: I have not tested this locally. I'm not quite at the point where I am able to do that. So there is some small risk, I think. If you are able to verify this change first, that would be good.

nosro avatar Sep 10 '22 19:09 nosro

If this looks like the way to go, I can update all the email templates with a greeting as part of this PR, or a follow-up.

nosro avatar Sep 10 '22 20:09 nosro

I can't decipher the automatic check GraphQL Inspector, "Error: Resource not accessible by integration".

Perhaps that is due to a remote PR from the fork.

nosro avatar Sep 10 '22 20:09 nosro

I think I've made an error in getting the user name. It looks like that might reside in the "userCollective". I'll make a change to get that.

nosro avatar Sep 12 '22 00:09 nosro

Hi @nosro, need any help on that one? Happy to take it from here if you don't have the time :slightly_smiling_face:

Betree avatar Oct 31 '22 15:10 Betree

Moved to https://github.com/opencollective/opencollective-api/pull/8204; I'll take it from there. thanks for your contribution @nosro!

Betree avatar Nov 22 '22 17:11 Betree