Norihiro Kamae

Results 112 comments of Norihiro Kamae

@exeldro, What is your usecase for this PR? A sidenote for Jim, I'm writing a filter that instantiates outputs at [norihiro/obs-output-filter](https://github.com/norihiro/obs-output-filter). My problem is how to separate `obs_data_t` for the...

Too long description in a line. There are 97 characters, where the limit is 72: > This feature adds a "Toggle window border" option to the projector window's context (popup)...

> Thanks, I added a new description in PR description Not the PR description but the commit description. You may edit it by `git commit --amend` and push to GitHub...

This bug was found during writing the RFC https://github.com/obsproject/rfcs/pull/61.

A line below contains more than 72 characters. > Allow to select any type of ScreenCast (monitor, window, virtual) with only

If you release this as a 3rd party plugin at https://obsproject.com/forum/plugins/, I think it would be welcome. To me, the output (`obs_output_t`) type is interesting because the monitor can just...

The commit message should be wrapped to 72 columns.

I'm sorry, there is one more nitpick on the commit message. The first word (`declare`) should be capitalized.

I'ld like to suggest folding commit message like below. ``` obs-filters: Factor out NVIDIA Audio effects Currently, the three NVIDIA Audio Effects (noise suppression, room echo removal, noise suppression +...

The problem was the line below in the commit has 89 characters. ``` A deprecation warning has been added to the noise suppression filter to ``` For the CR LF,...