obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

Published 20 hours ago • verified publisher icon obsproject

UI: Allow hiding projector window frames

Open fsworld009 opened this issue 1 year ago • 10 comments

Description

Support toggling projector window border via context menu or settings.

Motivation and Context

This branch is created by rebasing #5818 from master and resolved conflicts. Open a new PR since I don't have permission to write to original PR. The branch is over 1.5 years old, have conflicts, and it seems the author isn't available to update the branch. Make this PR so it could be reviewed and merged in.

Note: some open discussion items on #5818:

  1. Linux testing: I did one in Nov.2022 and it looked fine
  2. QSizeGrip: per this comment it seems not supported in MacOS. But I suppose resize in frameless mode can be covered in #7851. Also, users can toggle frame/frameless from context menu so I personally think this is not necessary to be a blocker.
  3. Warchamp7's comment , which is already implemented:

    The setting under General is only a default. I would expect the same behaviour here.

How Has This Been Tested?

Build and tested on Windows 10

Edition	Windows 10 Pro
Version	21H2
Installed on	‎6/‎6/‎2020
OS build	19044.3086
Experience	Windows Feature Experience Pack 1000.19041.1000.0

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

fsworld009 avatar Aug 14 '23 14:08 fsworld009

Hi @WizardCM @Warchamp7 could you help reviewing discussions in #5818 and see if there's anything left to do other than QSizeGrip? I am hoping we could skip GSizeGrip now since we can address resize issues with #7851

If there's no other items, could you help review the PR?

c.,c. original author @davidmyersdev

fsworld009 avatar Aug 14 '23 16:08 fsworld009

Too long description in a line. There are 97 characters, where the limit is 72:

This feature adds a "Toggle window border" option to the projector window's context (popup) menu.

norihiro avatar Aug 16 '23 03:08 norihiro

@norihiro Thanks, I added a new description in PR description

fsworld009 avatar Aug 16 '23 04:08 fsworld009

Thanks, I added a new description in PR description

Not the PR description but the commit description. You may edit it by git commit --amend and push to GitHub by git push --force-with-lease.

norihiro avatar Aug 26 '23 16:08 norihiro

Force pushed to update commit description.

fsworld009 avatar Aug 27 '23 04:08 fsworld009

@fsworld009 thanks so much for taking this over. 🙌

davidmyersdev avatar Oct 14 '23 22:10 davidmyersdev

Any updates on this? It's been pending review for awhile.

emmafaye avatar Jan 18 '24 01:01 emmafaye

@emmafaye Still pending review from maintainers

fsworld009 avatar Jan 27 '24 01:01 fsworld009

Did some testing. I made a small adjustment to disable the setting and window re-creation for fullscreen projectors.

Ready for testing on Mac/Linux and potential merge.

Warchamp7 avatar Apr 11 '24 03:04 Warchamp7

This would be really helpful to have

alasdairmackenzie avatar Jun 25 '24 14:06 alasdairmackenzie