obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

linux-pipewire: Unify ScreenCast source as Screen Capture v2

Open tytan652 opened this issue 10 months ago • 3 comments

Description

Allow to select both main type of ScreenCast (monitor, window) with only one source type rather than adding a source type per ScreenCast type.

This change is made as a version 2 of the Screen Capture which deprecates the use of Window Capture.

Why v2 rather than modifying v1 ?

I can't check or predict all portals implementation, and if one them create a restore token based on the asked types rather than selected sources. Not doing a v2 might introduce unwanted breaks.

Screenshots

GNOME monitor-only screencast selector (shown by screen capture v1): Screenshot from 2024-04-21 01-48-09

GNOME window-only screencast selector (shown by deprecated window capture): Screenshot from 2024-04-21 01-48-24-obfuscated

GNOME monitor+window screencast selector (shown by screen capture v2):

Screenshot from 2024-04-22 23-15-35

Motivation and Context

The way the ScreenCast portal was designed does not require a OBS source type per ScreenCast type, but the feature was introduced as 1:1 towards X11 implementations.

But unlike on X11, there is also other types like virtual type for virtual monitor that can be used by Desktop Environment (or one for applications once I finish my app to app portal).

And I think rather than adding a third OBS source type, it would better to unify them like macOS has one OBS source type for SCK.

How Has This Been Tested?

  • Added a Screen Capture with normal build
  • Open OBS build with this PR, the Screen Capture (v1) was still working
  • Adding a new Screen Capture allow to chose between the three ScreenCast type.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

tytan652 avatar Apr 18 '24 11:04 tytan652

A line below contains more than 72 characters.

Allow to select any type of ScreenCast (monitor, window, virtual) with only

norihiro avatar Apr 19 '24 04:04 norihiro

Can someone get screenshots or video of the unified ScreenCaptureKit source workflow on macOS works? I'd like to try and keep the experience as similar as we reasonably can across operating systems.

Warchamp7 avatar Apr 22 '24 20:04 Warchamp7

Can someone get screenshots or video of the unified ScreenCaptureKit source workflow on macOS works? I'd like to try and keep the experience as similar as we reasonably can across operating systems.

https://obsproject.com/kb/display-capture-sources#macos-sck

macOS Screen Capture properties window

tytan652 avatar Apr 22 '24 21:04 tytan652

Window capture is now obsoleted which do not show in the add source menu.

tytan652 avatar May 06 '24 21:05 tytan652

Seems like it continues to work as expected on sway as well.

kkartaltepe avatar May 09 '24 02:05 kkartaltepe