node icon indicating copy to clipboard operation
node copied to clipboard

test: update wpt url status

Open cola119 opened this issue 1 year ago • 1 comments

urlencoded-parser.any.js is now passed thanks to https://github.com/nodejs/undici/pull/1563, which is released in undici v5.8.1

cola119 avatar Aug 08 '22 14:08 cola119

CI: https://ci.nodejs.org/job/node-test-pull-request/45924/

nodejs-github-bot avatar Aug 08 '22 15:08 nodejs-github-bot

Commit Queue failed
- Loading data for nodejs/node/pull/44175
✔  Done loading data for nodejs/node/pull/44175
----------------------------------- PR info ------------------------------------
Title      test: update wpt url status (#44175)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     cola119:update-url-status -> nodejs:main
Labels     test, author ready, needs-ci
Commits    1
 - test: update wpt url status
Committers 1
 - cola119 
PR-URL: https://github.com/nodejs/node/pull/44175
Reviewed-By: Michaël Zasso 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Feng Yu 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44175
Reviewed-By: Michaël Zasso 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Feng Yu 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 08 Aug 2022 14:31:25 GMT
   ✔  Approvals: 4
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065324586
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065342638
   ✔  - Feng Yu (@F3n67u): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065381517
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065631496
   ✖  This PR needs to wait 8 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-08-08T15:11:35Z: https://ci.nodejs.org/job/node-test-pull-request/45924/
- Querying data for job/node-test-pull-request/45924/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2830437356

nodejs-github-bot avatar Aug 10 '22 06:08 nodejs-github-bot

Fast-track has been requested by @targos. Please 👍 to approve.

github-actions[bot] avatar Aug 10 '22 06:08 github-actions[bot]

Landed in 3028af95de2c76a3763b6718ec3e5731df636152

nodejs-github-bot avatar Aug 10 '22 06:08 nodejs-github-bot

This causes jstests to fail:

Error: Found 1 unexpected failures. Consider updating test/wpt/status/url.json for these files:
urlencoded-parser.any.js
    at process.<anonymous> (/home/juanarbol/GitHub/node/test/common/wpt.js:496:15)
    at process.emit (node:events:525:35)
Command: out/Release/node /home/juanarbol/GitHub/node/test/wpt/test-url.js

juanarbol avatar Oct 03 '22 02:10 juanarbol