node
node copied to clipboard
test: update wpt url status
urlencoded-parser.any.js
is now passed thanks to https://github.com/nodejs/undici/pull/1563, which is released in undici v5.8.1
CI: https://ci.nodejs.org/job/node-test-pull-request/45924/
Commit Queue failed
- Loading data for nodejs/node/pull/44175 ✔ Done loading data for nodejs/node/pull/44175 ----------------------------------- PR info ------------------------------------ Title test: update wpt url status (#44175) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cola119:update-url-status -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: update wpt url status Committers 1 - cola119https://github.com/nodejs/node/actions/runs/2830437356PR-URL: https://github.com/nodejs/node/pull/44175 Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel Reviewed-By: Feng Yu Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44175 Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel Reviewed-By: Feng Yu Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 08 Aug 2022 14:31:25 GMT ✔ Approvals: 4 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065324586 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065342638 ✔ - Feng Yu (@F3n67u): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065381517 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065631496 ✖ This PR needs to wait 8 more hours to land ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-08-08T15:11:35Z: https://ci.nodejs.org/job/node-test-pull-request/45924/ - Querying data for job/node-test-pull-request/45924/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
Fast-track has been requested by @targos. Please 👍 to approve.
Landed in 3028af95de2c76a3763b6718ec3e5731df636152
This causes jstests to fail:
Error: Found 1 unexpected failures. Consider updating test/wpt/status/url.json for these files:
urlencoded-parser.any.js
at process.<anonymous> (/home/juanarbol/GitHub/node/test/common/wpt.js:496:15)
at process.emit (node:events:525:35)
Command: out/Release/node /home/juanarbol/GitHub/node/test/wpt/test-url.js