nan

nan copied to clipboard

Add link to NewOneByteString in docs/new.md

1

SiarheiFedartsou

Nan::SetProperty (const char * version of Nan::Set to match Nan::SetMethod)

4

Perhaps I missed it, but there does not appear to be a convenience method that lets you just pass a C string for the property name to `Nan::Set` like you...

tolmasky

These two files got committed with CRLF line endings, while the rest of the repo uses LF line endings. This PR changes the line endings in these two files to...

dsanders11

Support Node 23

6

V8 Was bumped, this would be a patch release, since I already claimed support for Node 23 in 2.22.0. Also fixes #978.

kkoopa

fix: electron v28 build failure due to setAcessor not having compatible signature

4

Possible fix for the issue reported on this closed issue: https://github.com/nodejs/nan/issues/936 This was probably introduced by https://github.com/nodejs/nan/pull/966 Let me know if there is a better way to fix this! This...

JCMais

Weak tests incompatible with V8 change

1

A recent V8 change, [4733273: [heap] Disallow JS execution in second pass callbacks.](https://chromium-review.googlesource.com/c/v8/v8/+/4733273), makes a strict change to `WeakCallbackInfo::SetSecondPassCallback`: > The second pass callback is **prohibited from executing JavaScript**. Embedders...

clavin

This is faster than accessing the BackingStore. API is available in V8 10.5+ per https://github.com/nodejs/node/issues/32226#issuecomment-1185423020. Manually tested in Node.js v18.20 and v20.

zbjornson

fix: handle removed `IdleNotificationDeadline`

3

See https://chromium-review.googlesource.com/c/v8/v8/+/5539852 - this has been removed upstream and will no longer build on newer V8 versions.

codebytere