nan icon indicating copy to clipboard operation
nan copied to clipboard

Weak tests incompatible with V8 change

Open clavin opened this issue 10 months ago • 1 comments

A recent V8 change, 4733273: [heap] Disallow JS execution in second pass callbacks., makes a strict change to WeakCallbackInfo::SetSecondPassCallback:

The second pass callback is prohibited from executing JavaScript. Embedders should schedule another callback in case this is required.

This condition is enforced at runtime and results in a crash. This change conflicts with NAN's weak tests, both written to run JS in the weak callback.

clavin avatar Apr 02 '25 17:04 clavin

This is resolved in 2.23.0 release.

agracio avatar Oct 18 '25 11:10 agracio