fix: electron v28 build failure due to setAcessor not having compatible signature
Possible fix for the issue reported on this closed issue: https://github.com/nodejs/nan/issues/936
This was probably introduced by https://github.com/nodejs/nan/pull/966
Let me know if there is a better way to fix this! This seems to be working for Electron v28, but I did not run the remaining tests I have.
Note that this issue is also reproducible with nodejs 22.12.0.
Note that this issue is also reproducible with nodejs 22.12.0.
hmmm, in that case maybe we should use the v8 version itself in the directive?
PR https://github.com/nodejs/nan/pull/1004 fixes Electron 28 build.
2.23.1 release fixes Electron 28 build, this PR can be closed.