nan icon indicating copy to clipboard operation
nan copied to clipboard

fix: electron v28 build failure due to setAcessor not having compatible signature

Open JCMais opened this issue 1 year ago • 4 comments

Possible fix for the issue reported on this closed issue: https://github.com/nodejs/nan/issues/936

This was probably introduced by https://github.com/nodejs/nan/pull/966

Let me know if there is a better way to fix this! This seems to be working for Electron v28, but I did not run the remaining tests I have.

JCMais avatar Dec 10 '24 14:12 JCMais

Note that this issue is also reproducible with nodejs 22.12.0.

kapouer avatar Dec 11 '24 18:12 kapouer

Note that this issue is also reproducible with nodejs 22.12.0.

hmmm, in that case maybe we should use the v8 version itself in the directive?

JCMais avatar Dec 12 '24 15:12 JCMais

PR https://github.com/nodejs/nan/pull/1004 fixes Electron 28 build.

agracio avatar Nov 03 '25 11:11 agracio

2.23.1 release fixes Electron 28 build, this PR can be closed.

agracio avatar Nov 05 '25 22:11 agracio