Noah Falk

Results 59 comments of Noah Falk

> Maybe we need to make it more discoverable. Yep I just hit the same problem. However thumbs up for opening this issue which let me solve the problem quickly...

> Is having information about all connection end reasons useful? What was the motivation to add the data initially? I can hypothesize a reason someone might find it useful (diagnosing...

As part of this change please also update the protocol doc stored here: https://github.com/dotnet/diagnostics/blob/main/documentation/design-docs/ipc-protocol.md

@dotnet/dotnet-monitor you probably want to take a look at this

I am closing old PRs that have had no progress in a long time. You are welcome to resume the work any time and open a new PR.

With SOS today I am not aware of any option better than educated guessing/detective work. What @Maoni0 wrote is a very good heuristic for "Is this a static field reference?"...

> I'm guessing that OpenTelemetry handles changing the status in its final output based on listening to other ASP.NET Core error events Yep, [it does](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs#L327). This is based on the...

> Is this necessary or a relic of an older pattern? I think that was to preserve an invariant that the Activity Duration and EndTime would be set prior to...

> e.g. do we disable any features because we're streaming). As I recall EventPipeEventSource has the same behavior regardless whether the Stream is backed by a file or a stream....