diagnostics icon indicating copy to clipboard operation
diagnostics copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Add IMAGE_FILE_MACHINE_ARM64X and IMAGE_FILE_MACHINE_ARM64EC

Open hoyosjs opened this issue 3 years ago • 5 comments

Co-authored-by: David Mason [email protected]

hoyosjs avatar Feb 09 '22 00:02 hoyosjs

Then this is not going to work - if we can get such value in both arm64 and x64 scenarios we might need something different to identify process arch.

hoyosjs avatar Feb 14 '22 17:02 hoyosjs

I think it will work. If SOS is running on x64 (either real or emulated), both SOS_TARGET_AMD64 and SOS_TARGET_ARM64 are defined so putting the checks for those two processor types in the SOS_TARGET_ARM64 section should work.

mikem8361 avatar Feb 14 '22 18:02 mikem8361

Should work the way Juan has it now.

mikem8361 avatar Feb 14 '22 18:02 mikem8361

ArchQuery/GetTargetMachine should return the target's process instruction architecture/machine (regardless of SOS's host). Right now it will return the ARM64 IMachine. I think David had mentioned there are cases where this value can be returned on x64 processes on arm64 machines. If that's true, this patch is incomplete. Otherwise, this fix seems fine as we define both targets for the x64 SOS.

hoyosjs avatar Feb 14 '22 19:02 hoyosjs

I am closing old PRs that have had no progress in a long time. You are welcome to resume the work any time and open a new PR.

noahfalk avatar Jul 18 '22 22:07 noahfalk

@hoyosjs can you review?

mikem8361 avatar Sep 11 '24 03:09 mikem8361