diagnostics icon indicating copy to clipboard operation
diagnostics copied to clipboard

Supports collecting GCSettingsEvent for gc-collect profile

Open cshung opened this issue 1 year ago • 6 comments

This change supports collecting GCSettingsEvent for gc-collect profile. The change will work for both dotnet-trace and dotnet-monitor.

The depends on the underlying mechanism built in https://github.com/dotnet/runtime/pull/101189

cshung avatar Apr 17 '24 16:04 cshung

As part of this change please also update the protocol doc stored here: https://github.com/dotnet/diagnostics/blob/main/documentation/design-docs/ipc-protocol.md

noahfalk avatar Apr 19 '24 07:04 noahfalk

fyi @dotnet/dotnet-monitor

noahfalk avatar Apr 22 '24 21:04 noahfalk

Test results on Windows.

Tool Arguments Rundown Behavior
dotnet monitor gc-collect (no rundown for 8, settings for 9)
  gc-collect + cpu (full rundown for 8, 9)
  gc-collect + metrics (no rundown for 8, settings for 9)
     
dotnet-trace gc-collect (no rundown for 8, settings for 9)
  gc-collect rundown true (full rundown for 8, 9)
  gc-collect rundown false (no rundown for 8, 9)

cshung avatar Apr 25 '24 01:04 cshung

@noahfalk, can we take a look at this again? With the latest code, I should have addressed all the comments above.

cshung avatar Apr 25 '24 21:04 cshung

@dotnet/dotnet-monitor you probably want to take a look at this

noahfalk avatar Apr 25 '24 23:04 noahfalk

@noahfalk, here is the third iteration with all the comments addressed again.

cshung avatar Apr 29 '24 16:04 cshung