diagnostics
diagnostics copied to clipboard
Supports collecting GCSettingsEvent for gc-collect profile
This change supports collecting GCSettingsEvent for gc-collect profile. The change will work for both dotnet-trace and dotnet-monitor.
The depends on the underlying mechanism built in https://github.com/dotnet/runtime/pull/101189
As part of this change please also update the protocol doc stored here: https://github.com/dotnet/diagnostics/blob/main/documentation/design-docs/ipc-protocol.md
fyi @dotnet/dotnet-monitor
Test results on Windows.
| Tool | Arguments | Rundown Behavior |
|---|---|---|
| dotnet monitor | gc-collect | (no rundown for 8, settings for 9) |
| gc-collect + cpu | (full rundown for 8, 9) | |
| gc-collect + metrics | (no rundown for 8, settings for 9) | |
| dotnet-trace | gc-collect | (no rundown for 8, settings for 9) |
| gc-collect rundown true | (full rundown for 8, 9) | |
| gc-collect rundown false | (no rundown for 8, 9) |
@noahfalk, can we take a look at this again? With the latest code, I should have addressed all the comments above.
@dotnet/dotnet-monitor you probably want to take a look at this
@noahfalk, here is the third iteration with all the comments addressed again.