Nathan Moinvaziri

Results 433 comments of Nathan Moinvaziri

You can use cmake to generate the visual studio projects and solutions.

I have GHA workflows in #506 too.

In one project, I have a bunch of arguments already setup via launchSettings.json. So on that project, I don't want to use Commandline Arguments, but I have to switch between...

# Test 1 ## Silesia-small ### HEAD https://github.com/zlib-ng/zlib-ng/commit/89763032d57e3da5301f4cd6e1f363e7a1f85f02 ``` OS: Windows 10 10.0.22000 AMD64 CPU: Intel64 Family 6 Model 158 Stepping 10, GenuineIntel Tool: ../zlib-ng/build-inf-develop/Release/minigzip.exe Levels: 0-9 Runs: 70 Trim...

# Test 2 ## Silesia-small ### HEAD https://github.com/zlib-ng/zlib-ng/commit/89763032d57e3da5301f4cd6e1f363e7a1f85f02 ``` OS: Windows 10 10.0.22000 AMD64 CPU: Intel64 Family 6 Model 158 Stepping 10, GenuineIntel Tool: ../zlib-ng/build-inf-develop/Release/minigzip.exe Levels: 0-9 Runs: 70 Trim...

As far as code size goes, I am not seeing any notable differences between HEAD and this PR.

My benchmarks are based on the first two commits. I am not seeing any real performance benefit to making the chunk copy functions `static inline` in commit 3.

The 3rd commit only adds about 1-2KB code size on x86.

The code is a lot more complex because we are using `sse2` chunk functions in `sse41`. It means I have to have two copies of those functions (one for the...

> So I'm not seeing significant differences with and without the inlining happening on the chunk functions. This confirms what I was seeing as well. Here were my benchmarks just...