Nathan Moinvaziri
Nathan Moinvaziri
> It seems there is already a property flag to decide running playTests.sh or not. Are you referring to `ZSTD_PLAYTESTS_FLAGS`? That appears to be just flags to pass into the...
I don't think that is it... I'm not sure how I would enable/disable that. I could do a check for `uname`? ```cmake find_program(UNAME uname) if (UNAME) // Must be shell...
Added check for uname.
There is another problem, that playTest.sh is triggered when the project is added with `EXCLUDE_FROM_ALL`. ``` add_subdirectory(${ZSTD_SOURCE_DIR}/build/cmake ${ZSTD_BINARY_DIR} EXCLUDE_FROM_ALL) ``` The problem is that `datagen` and apps are not built...
Also is it weird that `add_test` still happens for `playTest` even if `ZSTD_BUILD_PROGRAMS` is OFF? Seems like the list of tests could be built as a list and playTest added...
I fixed the logic around the uname detection, but don't have a solution for detecting if datagen will be built.
> Seems like the list of tests could be built as a list and playTest added conditionally. Instead of creating the test and then disabling it.. Looks like using `DISABLED`...
> Does it matter if datagen is built? Yes, it does matter because `playTests.sh` depends on `datagen` and runs it. If include `zstd` using `add_subdirectory(zstd EXCLUDE_FROM_ALL)` then `datagen` will not...
> Is there a public link to this issue? It requires Feedback Hub app: https://aka.ms/AAic9qq