Naman Goel

Results 403 comments of Naman Goel

Great summary! Small addition to the second point: > We reiterated (mostly) that interesttarget should only invoke popovers (including ) but should not invoke modal dialogs. Mostly the reasoning is...

just a quick heads up that before leaving, I rolled out the new hovercard implementation for Facebook.com to 100% of public, if you want to play around with a user-space...

1. You should never use `runtimeInjection` in a next app with `app` dir. 2. Are you sure you're not pre-compiling the design system package?

You can nest differently to reduce the duplication: ```tsx const styles = stylex.create({ container: { marginBottom: { default: { default: '0.5rem', '@media screen and (min-width: 800px)': '0.75rem', }, ':last-child': 0,...

Just adding some details for this task. ## When inline styles are possible - We can use inline styles directly for longhand CSS properties - We cannot safely use inline...

> is it the same as #737 or something else? No, this is to detect CSS variables defined with `stylex.defineVars` that are never re-assigned and inlining them in the generated...

Here's a screen recording of the problem. https://github.com/user-attachments/assets/9b521fc8-1868-4e7f-8f60-db92b6e42627 Expected behavior: auto-fixing any error should sort *all* keys in the object.

@yousoumar The problem is that fixing one problem can create another problem. Notice how when I fix the `left`, it `opacity` becomes a problem again. The only way an autofix...

> Order CSS correctly but don't use @layer or a polyfill. This is not entirely possible. Based on the StyleX design for media queries and pseudo classes, all longhand styles...

This bug was discovered previously and fixed. The css variable should not be set to anything and the actual property should be set to undefined as well which should get...