Naman Goel

Results 403 comments of Naman Goel

abandoning this for now in favour of showing the Postcss plugin.

I see a prettier check failing. Could you fix that? The changes themselves look good.

@EvanBacon I looked at the transformer for Nativewind web and I found the following code: ```tsx if (isWeb) { return worker.transform( config, projectRoot, filename, Buffer.from(`require('${config.nativewind.output}');`, "utf8"), options, ); } ```...

There seems to be a Flow bug with the `StringPrefix` type still when being used in an object type as in the PR.

> `Type 'StyleXVar' is not assignable to type '_StyleXVar'` This seems to be the core issue. Let me investigate.

@mobalti Could you please explain why this is a priority for you? `styleResolution: 'legacy-expand-shorthands'` is something that no one should be using and it's a setting that we use internally...

> the library converts all logical properties to their physical equivalents, such as changing "block-size" to "height" and "inline-size" to "width." @mobalti This is not completely accurate. Logical styles such...

> Could this become an automatic compiler optimization for functional style rules? To some extent yes. I'm currently thinking through the patterns that could be detected and optimised. Some half-formed...

Yeah, that's a great idea and it's something that should be doable without a huge refactor. Let me create a new issue for this.

I think the challenge is that both file transformation *and* the metadata for each file needs to be cached. This has been challenging with most bundlers, but there should be...