Niels Lohmann
Niels Lohmann
I downloaded it and built it myself. It's indeed a pain I hope to fix soon.
~~Oh, I see we are not executing the test suite with disabled implicit conversions. I will take care of this.~~ We actually do check with in job `ci_test_noimplicitconversions`.
Will check #3859 after merging.
@theodelrieu AppVeyor complains: https://ci.appveyor.com/project/nlohmann/json/builds/51095672/job/s37fb0m5ggp1qyfc
In `.github/external_ci/appveyor.yml`, can you try changing ```yaml - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019 configuration: Release platform: x86 CXX_FLAGS: "/W4 /WX" CMAKE_OPTIONS: "-DJSON_ImplicitConversions=OFF" GENERATOR: Visual Studio 16 2019 ``` to ```yaml -...
Uff, AppVeyor is still failing... I will see if I can update the jobs there to the CI.cmake file. If I can't do this tomorrow, it will take some more...
No. I'll have a look at it. Appveyor has been pretty neglected over the years.
Yes, there seems to be a logic error. `\334` is written to the string buffer, but then overwritten by `\u0005`. The reason for this is line ```cpp bytes = bytes_after_last_accept;...
I had another look at the issue and this needs some discussion: - Right now, the `error_handler_t::ignore` option has few test cases, but these in connection with the current implementation...
Thanks for the input. Any preference on the name? `error_handler_t::keep`?