Niels Lohmann comments

Results 421 comments of


                                            Niels Lohmann

Fix cppcheck 1.5.1 warning

PTAL: #4758. I currently fail to create a test case for this.

Build ci_module_cpp20 with MSVC

Fixed by #4952.

Latest tag not available on NuGet

Please file a report somewhere at NuGet.

Getting a weak-vtables warning with clang on ubuntu 22.04

Indeed we compile with `-Wno-weak-vtables` in the CI. I will have a look.

Getting a weak-vtables warning with clang on ubuntu 22.04

Ok, I'm getting to the boundaries of my C++ knowledge. I can fix the `-Wweak-vtables` warning by adding ```cpp ~exception() override; ``` to the class definition and add ```cpp exception::~exception()...

Getting a weak-vtables warning with clang on ubuntu 22.04

I added a diagnostic push to suppress the warning in #4500. PTAL.

json start/end position implementation

Thanks for the effort! However, adding two `size_t` members is a lot of overhead. When we introduced diagnostics, we hid a single pointer behind a preprocessor macro to avoid every...

json start/end position implementation

A very wild idea: why not adding another macro like DIAGNOSTIC_POSITIONS and implement this without inheritance?

json start/end position implementation

> The ci_clang_tidy job keeps complaining about the parser callback being passed by value in json_sax, but that’s not really any code we’re modifying in this PR. What’s the suggestion...

json start/end position implementation

> > ## 🔴 Amalgamation check failed! 🔴 > > The source code has not been amalgamated. @sushshring Please read and follow the [Contribution Guidelines](https://github.com/nlohmann/json/blob/develop/.github/CONTRIBUTING.md#files-to-change). > > Not sure why...