Niels Lohmann
Niels Lohmann
@gentooise @t-b @jordan-hoang Please take a look at #4555.
In #4498 I added the code above as test case. I get the same assertion error in the job for GCC 10.5. Furthermore, the test does not compiler with Clang...
So the feature works as expected with reasonably modern versions of GCC and Clang. The assertion in GCC 10.5.0 feels to me like a shortcoming of the implementation of `std::views::filter`....
> @nlohmann Hi! I'm not done at all with this but I would need to see the result somewhere before continuing. Does the ci makes a documentation build? I didnt...
Please resolve conflicts and sign off your commits (see https://github.com/nlohmann/json/pull/4587/checks?check_run_id=35268369393).
> * I can't seem to satisfy DCO, could you point me to my mistake? I did add the signature to the commits. See https://github.com/nlohmann/json/pull/4587/checks?check_run_id=40451156048. There, a solution is described:...
I created #4801 to fix the CI. Please rebase once this is merged.
#4801 is merged. Please rebase.
Please rebase to the latest `develop` branch.
LGTM. The PR is still in draft though. 🤔