nkdengineer

Results 272 comments of nkdengineer

## Proposal ### Please re-state the problem that we are trying to solve in this issue. The error message remains displayed even after clicking the "Close" button. ### What is...

## Proposal ### Please re-state the problem that we are trying to solve in this issue. The error message displayed when attempting to proceed without selecting a bank while adding...

## Proposal ### Please re-state the problem that we are trying to solve in this issue. System message changes in the #admins room after changing WS description. "updated the description...

> I think a unit test might be appropriate here though? If we want I think we can add a unit test for `getMessageOfOldDotReportAction` with `CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.UPDATE_DESCRIPTION` and verify that the...

> I guess it doesn't make sense to add a new translation for POLICYCHANGELOG_UPDATE_DESCRIPTION We already do this for update room description so I think we can do the same...

@trjExpensify What do you think about my comment here https://github.com/Expensify/App/issues/53534#issuecomment-2517975987?

> Do other actualy workspace change logs to settings on the workspace get translated now,  @trjExpensify Yes some other change logs like remove/invite member, update workspace name,... have already translated.

@trjExpensify I think this because we have many workspace change logs action, we're only focusing on the translation for the popular system logs mentioned above.

@trjExpensify If we don't have a group workspace, the subscription page will not be found. What should we do in this case for `Learn more` link?