App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2024-12-09] [HOLD for payment 2024-12-07] Track expense - App opens not here page from Learn more link in upgrade modal

Open IuliiaHerets opened this issue 1 year ago • 16 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.68-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new account (no workspace).
  3. Go to self DM.
  4. Track a manual expense.
  5. Click Categorize it.
  6. Click Learn more link in the upgrade modal.

Expected Result:

App will open valid page.

Actual Result:

App opens not here page from Learn more link in upgrade modal.

Workaround:

Unknown

Platforms:

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [x] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/796b7684-f353-46b0-93a5-552426b71401

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify

IuliiaHerets avatar Nov 28 '24 14:11 IuliiaHerets

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Nov 28 '24 14:11 melvin-bot[bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 28 '24 14:11 melvin-bot[bot]

💬 A slack conversation has been started in #expensify-open-source

melvin-bot[bot] avatar Nov 28 '24 14:11 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Nov 28 '24 14:11 github-actions[bot]

@nkdengineer @Ollyws probably from this https://github.com/Expensify/App/pull/52737

mountiny avatar Nov 28 '24 14:11 mountiny

@trjExpensify If we don't have a group workspace, the subscription page will not be found. What should we do in this case for Learn more link?

nkdengineer avatar Nov 28 '24 15:11 nkdengineer

Not a blocker, pretty minor. I think we can link them here instead: https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Plan-types-and-pricing

trjExpensify avatar Nov 28 '24 15:11 trjExpensify

Got it. @mountiny Please assign me here and I will raise a follow-up PR.

nkdengineer avatar Nov 28 '24 15:11 nkdengineer

@trjExpensify Can you also assign @Ollyws here?

nkdengineer avatar Nov 28 '24 16:11 nkdengineer

@Ollyws The PR is ready for review.

nkdengineer avatar Nov 28 '24 16:11 nkdengineer

PR is CP'd and tested well, this is no longer a blocker

mjasikowski avatar Nov 29 '24 14:11 mjasikowski

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Nov 30 '24 14:11 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.68-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/53255

If no regressions arise, payment will be issued on 2024-12-07. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @Ollyws requires payment through NewDot Manual Requests
  • @nkdengineer requires payment (Needs manual offer from BZ)

melvin-bot[bot] avatar Nov 30 '24 14:11 melvin-bot[bot]

@Ollyws @trjExpensify @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Nov 30 '24 14:11 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.69-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/53255

If no regressions arise, payment will be issued on 2024-12-09. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @Ollyws requires payment through NewDot Manual Requests
  • @nkdengineer requires payment (Needs manual offer from BZ)

melvin-bot[bot] avatar Dec 02 '24 21:12 melvin-bot[bot]

@Ollyws @trjExpensify @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Dec 02 '24 21:12 melvin-bot[bot]

Payment Summary

Upwork Job

  • Reviewer: @Ollyws owed $250 via NewDot
  • ROLE: @nkdengineer paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

  • [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • [ ] I have verified the payment summary above is correct

melvin-bot[bot] avatar Dec 09 '24 09:12 melvin-bot[bot]

Same as here, right?

trjExpensify avatar Dec 09 '24 10:12 trjExpensify

Closing this out to consolidate on the OG issue linked.

trjExpensify avatar Dec 11 '24 10:12 trjExpensify