[HOLD for payment 2024-12-09] [HOLD for payment 2024-12-07] Track expense - App opens not here page from Learn more link in upgrade modal
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.68-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Create a new account (no workspace).
- Go to self DM.
- Track a manual expense.
- Click Categorize it.
- Click Learn more link in the upgrade modal.
Expected Result:
App will open valid page.
Actual Result:
App opens not here page from Learn more link in upgrade modal.
Workaround:
Unknown
Platforms:
- [ ] Android: Standalone
- [ ] Android: HybridApp
- [x] Android: mWeb Chrome
- [ ] iOS: Standalone
- [ ] iOS: HybridApp
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/796b7684-f353-46b0-93a5-552426b71401
Issue Owner
Current Issue Owner: @trjExpensify
Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
💬 A slack conversation has been started in #expensify-open-source
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@nkdengineer @Ollyws probably from this https://github.com/Expensify/App/pull/52737
@trjExpensify If we don't have a group workspace, the subscription page will not be found. What should we do in this case for Learn more link?
Not a blocker, pretty minor. I think we can link them here instead: https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Plan-types-and-pricing
Got it. @mountiny Please assign me here and I will raise a follow-up PR.
@trjExpensify Can you also assign @Ollyws here?
@Ollyws The PR is ready for review.
PR is CP'd and tested well, this is no longer a blocker
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.68-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/53255
If no regressions arise, payment will be issued on 2024-12-07. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @Ollyws requires payment through NewDot Manual Requests
- @nkdengineer requires payment (Needs manual offer from BZ)
@Ollyws @trjExpensify @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.69-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/53255
If no regressions arise, payment will be issued on 2024-12-09. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @Ollyws requires payment through NewDot Manual Requests
- @nkdengineer requires payment (Needs manual offer from BZ)
@Ollyws @trjExpensify @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Payment Summary
Upwork Job
- Reviewer: @Ollyws owed $250 via NewDot
- ROLE: @nkdengineer paid $(AMOUNT) via Upwork (LINK)
BugZero Checklist (@trjExpensify)
- [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct
Same as here, right?
Closing this out to consolidate on the OG issue linked.