[$250] The error message displayed when attempting to proceed without selecting a bank while adding a feed is unclear

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.71-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @joekaufmanexpensify Slack conversation (hyperlinked to channel name): ts_external_expensify_expense

Action Performed:

1. Enable company card in workspace
2. Click Add card
3. Without choosing any bank click Next

Expected Result:

Error message displayed for not selecting bank

Actual Result:

The error message displayed when attempting to proceed without selecting a bank while adding a feed is unclear. It states: "Please select a bank account before continuing."

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Standalone
• [ ] Android: HybridApp
• [ ] Android: mWeb Chrome
• [x] iOS: Standalone
• [x] iOS: HybridApp
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021865184188126712540
• Upwork Job ID: 1865184188126712540
• Last Price Increase: 2024-12-06

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot[bot]]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message displayed when attempting to proceed without selecting a bank while adding a feed is unclear

What is the root cause of that problem?

We are defining error message here with the message "Please select a bank account before continuing." and it is not clear because we are not adding a bank account.

https://github.com/Expensify/App/blob/0eec30d00c131d3f9caacf1de6afd33c83bc351e/src/languages/en.ts#L3313

What changes do you think we should make in order to solve the problem?

We can change this to "Please select a bank before continuing." or something to make it clearer

https://github.com/Expensify/App/blob/0eec30d00c131d3f9caacf1de6afd33c83bc351e/src/languages/en.ts#L3313

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[narefyev91]

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

[dukenv0307]

I already worked on company card project so I would like to take it as C+

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021865184188126712540

[melvin-bot[bot]]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.72-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/53551

If no regressions arise, payment will be issued on 2024-12-16. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @dukenv0307 requires payment through NewDot Manual Requests

[melvin-bot[bot]]

@dukenv0307 @alexpensify @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[alexpensify]

Payment Summary:

Contributor: @narefyev91 payment handled via vendor Contributor+: @dukenv0307 owed $250 via NewDot

@dukenv0307 - On Monday, please submit a payment request in NewDot.

---

Heads up, I will be offline until Wednesday, December 18, 2024, and will not actively watch over this GitHub during that period.

If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.

[JmillsExpensify]

$250 approved for @dukenv0307